-
Notifications
You must be signed in to change notification settings - Fork 3k
Moved STDIO_UART defines for UBLOX_EVK_ODIN_W2 #5192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved STDIO_UART defines for UBLOX_EVK_ODIN_W2 #5192
Conversation
👍 Looks good to me |
Thanks for enabling this. |
@andreaslarssonublox Could you rebase to resolve the conflict? |
f2d6a97
to
120c9ad
Compare
Rebased @theotherjimmy |
thanks! @0xc0170 Could you review? |
@andrewc-arm Any update? |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sorry. There was massive 10-days holiday just finished and there are tons of other issues. I will get back to this later. |
Description
Moved STDIO_UART defines to targets.json for UBLOX_EVK_ODIN_W2 instead of hardcoded.
The default UART(D2/D8) can be overriden in mbed_app.json like this to use UART_3 instead:
Status
Should be reviewed and tested by @andrewc-arm to make sure it solves #5129
Migrations
NO
Related PRs
#5129
Todos
None
Deploy notes
None
Steps to test or reproduce
Have only run one test case to verify that it is still possible to run 'mbed test'.