Skip to content

Moved STDIO_UART defines for UBLOX_EVK_ODIN_W2 #5192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andreaslarssonublox
Copy link

Description

Moved STDIO_UART defines to targets.json for UBLOX_EVK_ODIN_W2 instead of hardcoded.
The default UART(D2/D8) can be overriden in mbed_app.json like this to use UART_3 instead:

"target_overrides": {
        "UBLOX_EVK_ODIN_W2": {
            "target.usb_tx": "D1",
            "target.usb_rx": "D0",
            "target.stdio_uart": "UART_3"
        }
}

Status

Should be reviewed and tested by @andrewc-arm to make sure it solves #5129

Migrations

NO

Related PRs

#5129

Todos

None

Deploy notes

None

Steps to test or reproduce

Have only run one test case to verify that it is still possible to run 'mbed test'.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2017

Should be reviewed and tested by @andrewc-arm to make sure it solves #5129

👍

Looks good to me

@andrewc-arm
Copy link
Contributor

Thanks for enabling this.
Due to being busy, I was not able to test this actually. I will do so later.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 29, 2017

cc @c1728p9 @deepikabhavnani

@theotherjimmy
Copy link
Contributor

@andreaslarssonublox Could you rebase to resolve the conflict?

@andreaslarssonublox andreaslarssonublox force-pushed the ublox_move_stdio_uart_defines branch from f2d6a97 to 120c9ad Compare October 2, 2017 15:46
@andreaslarssonublox
Copy link
Author

Rebased @theotherjimmy

@theotherjimmy
Copy link
Contributor

thanks! @0xc0170 Could you review?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2017

@andrewc-arm Any update?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2017

cc @bulislaw @c1728p9

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 7, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Oct 7, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1541

All builds and test passed!

@andrewc-arm
Copy link
Contributor

Sorry. There was massive 10-days holiday just finished and there are tons of other issues. I will get back to this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants