Correct LWIP_DEBUG definition #4997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit f602c93 incorrectly started defining LWIP_DEBUG as either 0 or 1. lwipopts.h locally was changed to use #if, but all existing users continued to use #ifdef. Therefore defining it to 0 was accidentally enabling it for quite a few users. This would have pulled in some unwanted lwIP code, and affected some drivers, eg k64f_emac.c allocating an extra 2K of stack. Correct lwipopts.h to either define it as 1 or leave it undefined, and change the #if tests back to #ifdef, so all are consistent.
0xc0170
approved these changes
Aug 31, 2017
|
cc @hasnainvirk |
|
cc @yogpan01 |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
/morph test-nightly |
1 similar comment
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f602c93 incorrectly started defining
LWIP_DEBUGas either0or1.lwipopts.h locally was changed to use
#if, but all existing users continued to use#ifdef. Therefore defining it to0was accidentally enabling it for quite a few users.This would have pulled in some unwanted lwIP code, and affected some drivers, eg k64f_emac.c allocating an extra 2K of stack.
Correct lwipopts.h to either define it as
1or leave it undefined, and change the#iftests back to#ifdef, so all are consistent.