Rtostimer tests #4947

fkjagodzinski · 2017-08-21T14:15:09Z

Description

RTOS RtosTimer:

added unit tests,
reworked API docs based on CMSIS-RTOS2 API docs.

Status

READY

0xc0170 · 2017-08-21T19:11:09Z

retest uvisor

0xc0170 · 2017-08-22T08:11:05Z

retest uvisor

fkjagodzinski · 2017-08-23T09:44:24Z

cc @bulislaw

bulislaw · 2017-08-23T11:15:22Z

TESTS/mbedmicro-rtos-mbed/rtostimer/main.cpp

+    osStatus stat = timer.stop();
+    TEST_ASSERT_EQUAL(osErrorResource, stat);
+
+    int32_t slots = sem.wait(0);


Why do we do that?

Since Semaphore has its own tests this assert is actually redundant. I'll fix that.

bulislaw · 2017-08-23T11:19:43Z

TESTS/mbedmicro-rtos-mbed/rtostimer/main.cpp

+    osStatus stat = timer.stop();
+    TEST_ASSERT_EQUAL(osErrorResource, stat);
+
+    int32_t slots = sem.wait(0);


Why? We should assume in this tests semaphores work fine (they have their own tests).

bulislaw · 2017-08-23T11:29:07Z

TESTS/mbedmicro-rtos-mbed/rtostimer/main.cpp

+ * Then timer stops
+ *     and elapsed time matches given delay
+ */
+void test_correct_delay()


What's the difference between this and test_oneshot_not_restarted

Since other test cases already check the accuracy of delays I removed this one.

bulislaw

@0xc0170 could you have a look

bulislaw · 2017-08-25T15:10:41Z

/morph test

mbed-bot · 2017-08-25T17:30:01Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1118

Build failed!

bulislaw · 2017-08-29T08:53:36Z

/morph test

mbed-bot · 2017-08-30T03:56:29Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1137

Test failed!

0xc0170 · 2017-08-31T11:20:43Z

TESTS/mbedmicro-rtos-mbed/rtostimer/main.cpp

+
+using namespace utest::v1;
+
+#define THREAD_STACK_SIZE 512


This is not used anywhere, neither creating multiple threads. Is the line 22 above also valid?

You're right. I'll remove that.

0xc0170 · 2017-08-31T11:44:51Z

TESTS/mbedmicro-rtos-mbed/rtostimer/main.cpp

+
+    sem.wait(0);
+    stat = timer.start(TEST_DELAY_MS);
+    uint32_t t1 = us_ticker_read();


I would recomend using Timer class instead of us ticker read to capture the duration (C++ classes should provide all its needed)

Sure, I'll update time measurement with Timers.

0xc0170 · 2017-09-04T10:06:51Z

@fkjagodzinski Any update?

theotherjimmy · 2017-09-21T14:13:23Z

/morph test

mbed-bot · 2017-09-22T01:55:13Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1354

Test failed!

0xc0170 · 2017-09-22T09:05:31Z

@fkjagodzinski please look at failures, related to this changeset

fkjagodzinski · 2017-09-22T11:07:55Z

I suppose the ci/morph-test is failing because of -DMBED_TRAP_ERRORS_ENABLED=1.

Tests need to check osStatus returned by RtosTimer::stop() and RtosTimer::start(), e.g. here. Since these methods call EvrRtxTimerError this leads to test failure when compiled with --profile=debug.

What is the preferred solution? Is it possible to use another profile for these tests?

0xc0170 · 2017-09-22T11:46:37Z

What is the preferred solution? Is it possible to use another profile for these tests?

One way could be to separate that failure to another test unit that would catch it via host script - that would pass if it catches the failure via serial. We got some tests like that already , can't recall from top of my head any now.

@c1728p9 or @pan- Any other suggestions?

c1728p9 · 2017-09-22T14:27:52Z

I would recommend adding an installable hook/callback into either error or EvrRtx*Error and assert that it is called in the test if the API is misused.

Redefine error() as noop to fix tests being aborted when compiled with -DMBED_TRAP_ERRORS_ENABLED=1.

fkjagodzinski · 2017-09-26T11:50:33Z

Pushed a fix that overrides error(). I'm not entirely sure if this is a correct approach though.

bulislaw · 2017-09-27T14:45:46Z

TESTS/mbedmicro-rtos-mbed/rtostimer/main.cpp

+ * which aborts test program.
+ */
+#if defined(MBED_TRAP_ERRORS_ENABLED) && MBED_TRAP_ERRORS_ENABLED
+void error(const char* format, ...) {


Should we validate in the function that causes an error it actually happens by setting some flag here?

Isn't that going too deep into internals? The RtosTimer API does not say anything about calling error().

True, you're right.

theotherjimmy · 2017-10-09T15:59:58Z

@c1728p9 @bulislaw Are you happy with the current version of this patch?

mbed-ci · 2017-10-09T17:38:10Z

Build : SUCCESS

Build number : 19
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/4947/

mbed-ci · 2017-10-13T12:56:13Z

Build : SUCCESS

Build number : 172
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/4947/

Triggering tests

/test mbed-os

mbed-ci · 2017-10-13T16:26:34Z

Test : SUCCESS

Build number : 72
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/4947/72

mbed-ci · 2017-10-16T18:57:05Z

Test : SUCCESS

Build number : 80
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/4947/80

fkjagodzinski · 2017-10-17T08:52:46Z

Unless anyone has any comments, the PR is ready. I don't have any more updates to push.

0xc0170 · 2017-10-17T11:59:35Z

Unless anyone has any comments, the PR is ready. I don't have any more updates to push.

We will rerun uvisor CI once their fix lands,m then this should be ready for integration

0xc0170 · 2017-10-18T13:36:37Z

/morph uvisor-test

mbed-ci · 2017-10-18T13:51:11Z

Build : SUCCESS

Build number : 227
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/4947/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-10-18T17:44:23Z

Test : SUCCESS

Build number : 114
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/4947/114

theotherjimmy added the needs: review label Aug 21, 2017

bulislaw reviewed Aug 23, 2017

View reviewed changes

fkjagodzinski force-pushed the rtostimer_tests branch from 77ad117 to 2a432b0 Compare August 23, 2017 13:11

bulislaw approved these changes Aug 25, 2017

View reviewed changes

0xc0170 reviewed Aug 31, 2017

View reviewed changes

fkjagodzinski added 2 commits September 4, 2017 16:10

RTOS: RtosTimer: Improve API docs

4b0cf63

Tests: RTOS: RtosTimer: Add tests

33e38cc

fkjagodzinski force-pushed the rtostimer_tests branch from 2a432b0 to 33e38cc Compare September 4, 2017 14:11

0xc0170 approved these changes Sep 4, 2017

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Sep 4, 2017

0xc0170 added needs: work and removed needs: CI labels Sep 22, 2017

Tests: RTOS: RtosTimer: Fix tests on debug profile

311d38b

Redefine error() as noop to fix tests being aborted when compiled with -DMBED_TRAP_ERRORS_ENABLED=1.

bulislaw reviewed Sep 27, 2017

View reviewed changes

theotherjimmy added needs: review and removed needs: work labels Oct 5, 2017

c1728p9 approved these changes Oct 9, 2017

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Oct 13, 2017

0xc0170 added ready for merge and removed needs: CI labels Oct 19, 2017

0xc0170 merged commit cbb8a1f into ARMmbed:master Oct 19, 2017

0xc0170 added ready for merge release-version: 5.6.3 and removed ready for merge labels Oct 19, 2017

adbridge removed the ready for merge label Oct 20, 2017

fkjagodzinski deleted the rtostimer_tests branch October 20, 2017 11:52

Rtostimer tests #4947

Rtostimer tests #4947

Uh oh!

Conversation

fkjagodzinski commented Aug 21, 2017

Description

Status

Uh oh!

0xc0170 commented Aug 21, 2017

Uh oh!

0xc0170 commented Aug 22, 2017

Uh oh!

fkjagodzinski commented Aug 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

bulislaw commented Aug 25, 2017

Uh oh!

mbed-bot commented Aug 25, 2017

Output

Uh oh!

bulislaw commented Aug 29, 2017

Uh oh!

mbed-bot commented Aug 30, 2017

Output

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Sep 4, 2017

Uh oh!

theotherjimmy commented Sep 21, 2017

Uh oh!

mbed-bot commented Sep 22, 2017

Output

Uh oh!

0xc0170 commented Sep 22, 2017

Uh oh!

fkjagodzinski commented Sep 22, 2017

Uh oh!

0xc0170 commented Sep 22, 2017

Uh oh!

c1728p9 commented Sep 22, 2017

Uh oh!

fkjagodzinski commented Sep 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theotherjimmy commented Oct 9, 2017

Uh oh!

mbed-ci commented Oct 9, 2017

Uh oh!

mbed-ci commented Oct 13, 2017

Triggering tests

Uh oh!

mbed-ci commented Oct 13, 2017