lpc1768: Remove invalid use of IP_SOF_BROADCAST_RECV option #4060
Conversation
From opt.h: IP_SOF_BROADCAST_RECV (requires IP_SOF_BROADCAST=1) enable the broadcast filter on recv operations. The IP_SOF_BROADCAST_RECV option does not enable or disable recieving broadcast packets, it only enables a software filter.
|
@geky It works fine. I posted the test result here: ARMmbed/mbed-os-example-sockets#17 (comment) |
|
/morph test-nightly |
|
@geky DHCP is working fine now with those changes. |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
The tests passed but there was a hiccup in the CI that prevented the results from showing up green. According to @studavekar this has been fixed. Since this requires the heaviest CI the rerun can probably wait until the CI is less busy. |
|
/morph test-nightly |
|
@bridadan Can you please restart nightly job? |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
We had an issue with one of the platforms in the test farm so I'm restarting this. /morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
From opt.h:
The IP_SOF_BROADCAST_RECV option does not enable or disable recieving broadcast packets, it only enables a software filter. The lpc1768 was using the IP_SOF_BROADCAST_RECV to disable recieving broadcasts entirely.
This resulted in an issue for certain DHCP servers, which apparently can respond to discover packets via broadcast.
Tested locally with with dump provided by @chrissnow
related: #4018, ARMmbed/mbed-os-example-sockets#17
cause: #3482
cc: @chrissnow, @toyowata, @kjbracey-arm