Skip to content

PSA: Fix compile error with NV seed #14850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Jul 1, 2021

Summary of changes

This PR tries to fix compile error which can reproduce when PSA V7M and MBEDTLS_ENTROPY_NV_SEED are both enabled. To reproduce the error, in mbed-os-example-blinky (tag mbed-os-6.12.0), add mbed_app.json with:

{
    "macros": [
        "MBEDTLS_ENTROPY_NV_SEED"
    ],
    "target_overrides": {
        "*": {
            "target.features_add": ["EXPERIMENTAL_API"]
        }
    }
}

Then build for K64 running:

mbed compile -m K64F -t ARM

Then meet compile error:

[Error] pal_mbed_os_intf.cpp@112,18: use of undeclared identifier 'MBEDTLS_ENTROPY_BLOCK_SIZE'

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

This compile error can reproduce when both PSA V7M and MBEDTLS_ENTROPY_NV_SEED are both enabled.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 1, 2021
@ciarmcom ciarmcom requested a review from a team July 1, 2021 10:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 1, 2021

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jul 1, 2021
@Patater
Copy link
Contributor

Patater commented Jul 1, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 1, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_tfm-integration ✔️

@Patater Patater merged commit 4e121a7 into ARMmbed:master Jul 2, 2021
@mergify mergify bot removed the ready for merge label Jul 2, 2021
@ccli8 ccli8 deleted the nuvoton_psa_nv_seed branch July 2, 2021 09:04
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants