Skip to content

Rename "default_lib" to "c_lib". #12278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2020
Merged

Rename "default_lib" to "c_lib". #12278

merged 2 commits into from
Jan 21, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jan 17, 2020 •
edited by 0xc0170
Loading

Summary of changes

  • Rename target.default_lib to target.c_lib as it is more meaningful. These changes are done only for MBED OS 5 targets and in the build tool.

Note:

  • Mbed OS-2 targets target.default_lib remains unchanged(No rename to target.c_lib).

Impact of changes

With these changes, target.default_lib attribute is no longer being supported.

Migration actions required

  • The target.c_lib is the new attribute used for C library selection. The choice remains unchanged("std" or "small")

Documentation

Refer Docs

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @bulislaw @madchutney

@rajkan01 rajkan01 changed the title Rename "default_lib" to "c_lib". Rename default_lib to c_lib. Jan 17, 2020
@rajkan01 rajkan01 changed the title Rename default_lib to c_lib. Rename "target.default_lib" to "c_lib". Jan 17, 2020
@rajkan01 rajkan01 changed the title Rename "target.default_lib" to "c_lib". Rename "default_lib" to "c_lib". Jan 17, 2020
@ciarmcom ciarmcom requested review from bulislaw, evedon, madchutney and a team January 17, 2020 16:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@bulislaw @madchutney @evedon @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools please review.

@rajkan01 rajkan01 force-pushed the feature_rename_default_lib branch from d634ca0 to 8a0fdd2 Compare January 17, 2020 16:06
0xc0170
0xc0170 previously approved these changes Jan 20, 2020
View reviewed changes
bulislaw
bulislaw previously approved these changes Jan 20, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Jan 20, 2020
evedon
evedon previously approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to also update any reference to default_lib in the docs.

@adbridge
Copy link
Contributor

You will need to also update any reference to default_lib in the docs.

@rajkan01 Will you raise a separate PR to do this update ? In the meantime I will start the CI on this one.

@adbridge
Copy link
Contributor

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Jan 21, 2020
@mbed-ci
Copy link

mbed-ci commented Jan 21, 2020

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@rajkan01
Copy link
Contributor Author

You will need to also update any reference to default_lib in the docs.

@rajkan01 Will you raise a separate PR to do this update ? In the meantime I will start the CI on this one.

I have already raised the PR for docs changes on PR#1197

@mergify mergify bot dismissed stale reviews from 0xc0170, bulislaw, and evedon January 21, 2020 12:26

Pull request has been modified.

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 21, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@adbridge
Copy link
Contributor

@rajkan01 there is something funny going on in the ci with this PR , will need input from the test team before I am comfortable progressing this

@adbridge
Copy link
Contributor

Not sure why CI reported failures and then gave all green. Going to re-run to check

@adbridge
Copy link
Contributor

CI re-started

@mbed-ci
Copy link

mbed-ci commented Jan 21, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@adbridge adbridge added ready for merge release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed needs: CI labels Jan 21, 2020
@adbridge adbridge merged commit ee1d998 into ARMmbed:master Jan 21, 2020
@marcuschangarm marcuschangarm mentioned this pull request Jan 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

@evedon evedon evedon left review comments

@madchutney madchutney Awaiting requested review from madchutney

+1 more reviewer

@bulislaw bulislaw bulislaw left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
BREAKING-CHANGE release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rajkan01 @ciarmcom @adbridge @mbed-ci @bulislaw @0xc0170 @evedon