Skip to content

Add sender address and port verification to UDPSOCKET_ECHOTEST #11836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Add sender address and port verification to UDPSOCKET_ECHOTEST #11836

merged 1 commit into from
Nov 8, 2019

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Nov 7, 2019

Description (required)

recvfrom method returns sender address and port and this commit
adds a test for it in UDPSOCKET_ECHOTEST.

Originally part of #11832.

Summary of change (What the change is for and why)
Documentation (Details of any document updates required)

Pull request type (required)

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

recvfrom method returns sender address and port and this commit
adds a test for it in UDPSOCKET_ECHOTEST.
@ciarmcom ciarmcom requested review from a team November 7, 2019 13:51
@ciarmcom
Copy link
Member

ciarmcom commented Nov 7, 2019

@kivaisan, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 8, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 8, 2019

Need to abort the job (ARM already failed, CI should be fixed, so restarting soon)

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 8, 2019

CI restarted ,failures do not make sense and some were even terminated

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit fe0ac4f into ARMmbed:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants