SocketAddress: add port check to compare operator #11832
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port is considered as a part of socket address and compare operator must also check if the port number is the same in both addresses. Added unittest and UDP echo test to compare addresses.
|
@kivaisan, thank you for your changes. |
AnttiKauppila
approved these changes
Nov 7, 2019
0xc0170
approved these changes
Nov 7, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
SeppoTakalo
approved these changes
Nov 7, 2019
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
|
Unittest failed, |
|
This requires more thinking and can be also a breaking change for existing applications. I'll close this PR and make a new one which just tests address and port in echotest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Summary of change (What the change is for and why)
Port is considered as a part of socket address and compare operator
must also check if the port number is the same in both addresses.
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
PR includes also new unittest to verify SocketAddress compare operator. Also added a check to UDPSOCKET_ECHOTEST to verify the received packet is sent by echo server from echo port.
Reviewers (optional)
@SeppoTakalo
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required