Fix the reset_reason host test in the CI #11742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a BaseHostTestAbstract.reset() method instead of BaseHostTestAbstract.reset_dut() for more consistent behavior with various platforms in the CI. In contrast to a local setup, the reset_dut() method flashes the binary again after performing the reset in a remote setup (RaaS). This was not intentional in reset_reason tests. Moreover, this led to a different behavior (a different reset_reason) for different flashing methods which are target specific.
ciarmcom
requested review from
jamesbeyond,
OPpuolitaival,
TuomoHautamaki and
a team
|
@fkjagodzinski, thank you for your changes. |
0xc0170
approved these changes
Oct 25, 2019
|
CI started |
Test run: SUCCESSSummary: 5 of 5 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a
BaseHostTestAbstract.reset()method instead ofBaseHostTestAbstract.reset_dut()for more consistent behavior with various platforms in the CI.In contrast to a local setup, the
reset_dut()method flashes the binary again after performing the reset in a remote setup (RaaS). This was not intentional in reset_reason tests. Moreover, this led to a different behavior (a different value of thereset_reason_tenum) for different flashing methods which are target specific.Pull request type
Reviewers
@TuomoHautamaki, @OPpuolitaival, @jamesbeyond
Release Notes