Skip to content

Missing errno.h include #11597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2019
Merged

Missing errno.h include #11597

merged 2 commits into from
Sep 30, 2019

Conversation

mirelachirica
Copy link
Contributor

Description

  • include of errno.h header is needed for Mac OS X: unititests failing to compile otherwise
  • removed usage of "endptr" from strtol() since its value is not used

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit dc64165 into ARMmbed:master Sep 30, 2019
@rolfmobile99
Copy link

Thanks Mirela, I just found the same issue on a MacOS build of "riscv-isa-sim", a RISC-V simulator!
Found your fix after a lot of googling.
So simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mirelachirica @mbed-ci @rolfmobile99 @0xc0170 @AnttiKauppila