Skip to content

make watchdog kick reset test pass CI (LSI problem) #11172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2019
Merged

make watchdog kick reset test pass CI (LSI problem) #11172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion TESTS/mbed_drivers/watchdog_reset/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,21 @@
#include "mbed.h"

#define TIMEOUT_MS 100UL
#define KICK_ADVANCE_MS 10UL

/* This value is used to calculate the time to kick the watchdog.
* Given the watchdog timeout is set to TIMEOUT_MS, the kick will be performed
* with a delay of (TIMEOUT_MS - KICK_ADVANCE_MS), after the init.
*
* It is common for the watchdog peripheral to use a low precision clock source,
* e.g. the LSI RC acts as a clock source for the IWDG on ST targets.
* According to the ST spec, the 37 kHz LSI is guaranteed to have a frequency
* around 37-38 kHz, but the actual frequency range guaranteed by the production
* tests is 26 kHz up to 56 kHz.
* Bearing that in mind, a 100 ms timeout value may actually last as long as 142 ms
* and as short as 66 ms.
* The value of 35 ms is used to cover the worst case scenario (66 ms).
*/
#define KICK_ADVANCE_MS 35UL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this value is no longer arbitrary, and is now based on real data, we should explain how it was determined.

Suggested change
#define KICK_ADVANCE_MS 35UL
/* This value is used to calculate the time to kick the watchdog.
* Given the watchdog timeout is set to TIMEOUT_MS, the kick will be performed
* with a delay of (TIMEOUT_MS - KICK_ADVANCE_MS), after the init.
*
* It is common for the watchdog peripheral to use a low precision clock source,
* e.g. the LSI RC acts as a clock source for the IWDG on ST targets.
* According to the ST spec, the 37 kHz LSI is guaranteed to have a frequency
* around 37-38 kHz, but the actual frequency range guaranteed by the production
* tests is 26 kHz up to 56 kHz.
* Bearing that in mind, a 100 ms timeout value may actually last as long as 142 ms
* and as short as 66 ms.
* The value of 35 ms is used to cover the worst case scenario (66 ms).
*/
#define KICK_ADVANCE_MS 35UL


#define MSG_VALUE_DUMMY "0"
#define CASE_DATA_INVALID 0xffffffffUL
Expand Down
16 changes: 15 additions & 1 deletion TESTS/mbed_hal/watchdog_reset/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,21 @@
#include "mbed.h"

#define TIMEOUT_MS 100UL
#define KICK_ADVANCE_MS 10UL

/* This value is used to calculate the time to kick the watchdog.
* Given the watchdog timeout is set to TIMEOUT_MS, the kick will be performed
* with a delay of (TIMEOUT_MS - KICK_ADVANCE_MS), after the init.
*
* It is common for the watchdog peripheral to use a low precision clock source,
* e.g. the LSI RC acts as a clock source for the IWDG on ST targets.
* According to the ST spec, the 37 kHz LSI is guaranteed to have a frequency
* around 37-38 kHz, but the actual frequency range guaranteed by the production
* tests is 26 kHz up to 56 kHz.
* Bearing that in mind, a 100 ms timeout value may actually last as long as 142 ms
* and as short as 66 ms.
* The value of 35 ms is used to cover the worst case scenario (66 ms).
*/
#define KICK_ADVANCE_MS 35UL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above -- add a comment explaining why 35 ms is used.


#define MSG_VALUE_DUMMY "0"
#define CASE_DATA_INVALID 0xffffffffUL
Expand Down