Skip to content

Fix ANALOGIN support for LPC55S69 #11127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2019
Merged

Fix ANALOGIN support for LPC55S69 #11127

merged 1 commit into from
Aug 20, 2019

Conversation

mmahadevan108
Copy link
Contributor

Description

  1. Update to handle 12-bit resolution
  2. Properly handle the pin configuration
  3. Update the pin setup to handle the ADC B channel

Verified with the FPGA test shield

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mmahadevan108
Copy link
Contributor Author

cc @maclobdell @c1728p9 @bulislaw

@ciarmcom ciarmcom requested review from maclobdell and a team July 30, 2019 15:00
@ciarmcom
Copy link
Member

@mmahadevan108, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@mmahadevan108
Copy link
Contributor Author

Anything else needed for this PR?

jamesbeyond
jamesbeyond approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@jamesbeyond
Copy link
Contributor

@0xc0170 do you know how can we re-start travis job. it was failed due to python package issue, but I believe now it got fixed

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

Travis restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

@0xc0170 do you know how can we re-start travis job. it was failed due to python package issue, but I believe now it got fixed

Was this on master and it is related to travis config? If yes, this should be rebased to get that update

@mmahadevan108
Fix ANALOGIN support for LPC55S69
10bbbd1 
1. Update to handle 12-bit resolution
2. Properly handle the pin configuration
3. Update the pin setup to handle the ADC B channel

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108 mmahadevan108 force-pushed the Fix_LPC55S69_AnalogIn branch from eeee8b3 to 10bbbd1 Compare August 9, 2019 14:18
@mmahadevan108
Copy link
Contributor Author

Rebased.

@mmahadevan108
Copy link
Contributor Author

Anything else needed for this?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 19, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit e56f319 into ARMmbed:master Aug 20, 2019
@mmahadevan108 mmahadevan108 deleted the Fix_LPC55S69_AnalogIn branch August 20, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 5.13.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmahadevan108 @ciarmcom @jamesbeyond @0xc0170 @mbed-ci @bulislaw