Add CC3220SF LAUNCHXL to Mbed OS #11041
Conversation
|
@linlingao, thank you for your changes. |
| @@ -107,7 +107,7 @@ void lp_ticker_info_test() | |||
|
|
|||
| TEST_ASSERT(p_ticker_info->frequency >= 4000); | |||
| TEST_ASSERT(p_ticker_info->frequency <= 64000); | |||
| TEST_ASSERT(p_ticker_info->bits >= 12); | |||
| TEST_ASSERT(p_ticker_info->bits >= 12 && p_ticker_info->bits <= 32); | |||
There was a problem hiding this comment.
The TI HW timer is 48bit. I initially set it to 48bit and ran into an issue. I reverse-engineered it and found out Mbed OS really just supports less than or equal to 32bit.
components/storage/blockdevice/COMPONENT_SD/TESTS/filesystem/dirs/main.cpp
Outdated
Show resolved
Hide resolved
| @@ -501,7 +501,7 @@ utest::v1::status_t greentea_failure_handler(const Case *const source, const fai | |||
| // Test setup | |||
| utest::v1::status_t test_setup(const size_t number_of_cases) | |||
| { | |||
| GREENTEA_SETUP(60, "default_auto"); | |||
| GREENTEA_SETUP(240, "default_auto"); | |||
There was a problem hiding this comment.
I don't like that, it's 4x the current value. Not knowing much about the the reasons I would say something else is going wrong.
There was a problem hiding this comment.
The test was timing out with the old value. I'll retested this with the latest code.
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
There was a problem hiding this comment.
Do we really need this XML file? How is it used?
There was a problem hiding this comment.
This is used by Code Composer Studio debugger. It tells the debugger what address ranges are valid.
targets/targets.json
Outdated
| "CC3220SF_LAUNCHXL": { | ||
| "inherits": ["CC3220SF"], | ||
| "components_add": ["SD", "FLASHIAP"], | ||
| "device_has": ["USTICKER", "SERIAL", "SERIAL_FC", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "INTERRUPTIN", "SPI", "ANALOGIN", "FLASH", "TRNG", "RTC"], |
There was a problem hiding this comment.
We don't implement sleep or lpticker?
There was a problem hiding this comment.
Sleep has not been implemented. I don't think it's a required feature in Mbed OS, but if there's a demand down the road, we can add it.
I implemented LPTICKER code but the long latency in their HW design makes it useless in Mbed OS.
|
@linlingao , would you please rebase your work on top of the master branch? Then it will be much easier to review. |
|
I've rebased 137 commits on top of the master. What a nightmare! I tried to squash the remaining 5 commits into one but ran into some issues. I think I've stretched github too thin. It shouldn't affect review/merge. |
|
Between this, psoc, the c++ and rtos api improvements; There seem to be a lot of big ones lately. Wondering what the trend is. |
|
History has a merge commits, cannot be accepted. You need to rebase your work on top of master, not merge from master. If you already rebased, and you had a merge commits, it becomes nightmare. Do a clean branch with only your changes. |
|
@SeppoTakalo The rebase of 137 commits appears to be too complex for Git (and me) to handle cleanly. I kept running into weird conflicts. I have submitted another one in #11063. |
|
@40Grit I think it's just coincidence. Hopefully the trend is, Mbed OS supports more boards with improved quality :). |
Description
Add CC3220SF LAUNCHXL to the Mbed OS family.
Pull request type
Reviewers
Release Notes