Deep sleep lock would overflow (> USHRT_MAX)

[betzw]

Description

• Type: Bug
• Priority: Blocker

---

Bug

mbed-os sha:
3f2e986 Merge pull request #5012 from LMESTM/issue5004_ticker_16b

Actual behavior
See stack_tasks.txt

[betzw]

Maybe class Timer requires a destructor now?
Similarly, class SerialBase requires to free lock, too.

[0xc0170]

This should be fixed by #5063. The issue was actually with Callbacks operato== (also fixed now on master). I'll close this, reopen with new findings if any

Thank you for reporting

[betzw]

Unfortunately #5063 does not fix this issue!
Whereas modifications like in this diff seem to fix my issue (see also my comment above).

[betzw]

@0xc0170, could you pls. re-open this issue.

[0xc0170]

OK, going to check

[0xc0170]

Timer has a problem with destructor - it is never stoped:

{
  {
    Timer timer;

    timer.start();
  }
// here timer object is out of scope, but it's running as nothing stopped it - it assumes us ticker is always running
}

Thus would be good to to define dtor with stoping the timer (unblock deepsleep if us ticker is involved).

SerialBase has an empty virtual dtor. It should not be empty in this case - assuming either attach or even async is invoked, then destroying the object does not clean its resources (no abort, or detach is involved).

We will propose a fix for this

cc @c1728p9

[screamerbg]

@0xc0170 @c1728p9 any idea about providing a fix for this? This is gating the WiFi driver @betzw is working on.

[0xc0170]

There's one improvement here #5148 (not yet fixing it). I'll create another PR to create Timer dtor as proposed above based on this improvement (will need it).

Regarding SerialBase - I'll talk to @c1728p9

[c1728p9]

Hi @betzw, it looks like one of the fixes in the diff you provided has already been made in #5095. I created #5220 which fixes the other problem shown in your diff (along with other potential problems).

@betzw can you try #5220 to confirm it fixes your problem?

[betzw]

I will try asap, but most likely today I won't have the time ... 😢

[betzw]

Yep, https://github.com/c1728p9/mbed-os/tree/sleep_lock_fixes seems to fix this issue.