UBLOX_EVK_ODIN_W2 missing BUTTON1 definition

[simosillankorva]

Description

• Type: Bug
• Priority: Minor

Bug

Target
UBLOX_EVK_ODIN_W2

Toolchain:
any

mbed-os sha:
4c256f0

Expected behavior
BUTTON1 expected to be defined.

Actual behavior
Not compiling if trying to use BUTTON1, it seems to be undefined.

[0xc0170]

cc @andreaslarssonublox @andreaspeterssonublox

[sg-]

Why do you think BUTTON1 should be defined?

[simosillankorva]

Is it not the standard name for the button nowdays? ad8f2fc

[0xc0170]

Is it not the standard name for the button nowdays? ad8f2fc

@kegilbert

[kegilbert]

We had added in a set of standardized button names to match how we map LED pins to LED1...LEDn.

#4249

This change hit around ~70 targets that had some form of button mapping but with an inconsistent set of names. There are still targets that have physical buttons but had no software definition for those buttons that will require going through and manually adding them.

[sg-]

No tests, no docs, not the standard.

[JanneKiiskila]

Why can't just fix this? It's no big deal to fix it and we have no intentions to start having the button definitions per board in the example client. @sg-

[JanneKiiskila]

How hard would it be to add the porting guide info here; https://docs.mbed.com/docs/mbed-os-handbook/en/latest/advanced/porting_guide/

• it really should not be too hard.
• we should also demand they run mbed-os-example-client in minimum.

[sg-]

Why can't just fix this?

Write some docs, create some tests and then start a review. That is the process for a 'feature request'. What is the defined behavior for boards that dont have any buttons?

[JanneKiiskila]

I would recommend you @sg- take a look at the original PR then, as this thing is not "our thing", we just spotted one mistake - #4249.

[0xc0170]

Write some docs, create some tests and then start a review. That is the process for a 'feature request'. What is the defined behavior for boards that dont have any buttons?

@kegilbert Can you please , if this has not been done (I noticed there was a request for docs in the original PR adding buttons) .