Skip to content

Commit e145ae3

Browse files
authored
Merge pull request #14881 from jeromecoutant/PR_LED1
Standard Pin Name: LED1 issue for targets without LED
2 parents feb48fc + 971d0dd commit e145ae3

File tree

3 files changed

+6
-5
lines changed
  • drivers/tests/TESTS/mbed_drivers/generic_tests
  • events/tests/TESTS/events/timing
  • hal/tests/TESTS/pin_names/generic

3 files changed

+6
-5
lines changed

drivers/tests/TESTS/mbed_drivers/generic_tests/main.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ void test_case_basic()
7676
"The quick brown fox jumps over the lazy dog");
7777
}
7878

79+
#ifdef LED1
7980
void test_case_blinky()
8081
{
8182
static DigitalOut myled(LED1);
@@ -84,6 +85,7 @@ void test_case_blinky()
8485
myled = !myled;
8586
}
8687
}
88+
#endif
8789

8890
void test_case_cpp_stack()
8991
{
@@ -113,7 +115,9 @@ utest::v1::status_t greentea_failure_handler(const Case *const source, const fai
113115
// Generic test cases
114116
Case cases[] = {
115117
Case("Basic", test_case_basic, greentea_failure_handler),
118+
#ifdef LED1
116119
Case("Blinky", test_case_blinky, greentea_failure_handler),
120+
#endif
117121
Case("C++ stack", test_case_cpp_stack, greentea_failure_handler),
118122
Case("C++ heap", test_case_cpp_heap, greentea_failure_handler)
119123
};

events/tests/TESTS/events/timing/main.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ float chisq(float sigma)
5959

6060

6161
Timer timer;
62-
DigitalOut led(LED1);
6362

6463
equeue_sema_t sema;
6564

@@ -120,8 +119,6 @@ void semaphore_timing_test()
120119
}
121120

122121
TEST_ASSERT_INT_WITHIN(5000, taken, delay * 1000);
123-
124-
led = !led;
125122
}
126123

127124
equeue_sema_destroy(&sema);

hal/tests/TESTS/pin_names/generic/main.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
Requirements specified in docs/design-documents/hal/0004-pin-names-general-guidelines.md
2525
*/
2626

27-
#ifndef LED1
28-
#error [NOT_SUPPORTED] Target is not following mbed-os pin names standard // Test is set as Skipped
27+
#if !defined LED1 && !defined BUTTON1
28+
#error [NOT_SUPPORTED] Target doesn't have any LED and BUTTON
2929
#else
3030

3131
using namespace utest::v1;

0 commit comments

Comments
 (0)