Skip to content

Commit 9c0e9eb

Browse files
committed
Standardize Docker image naming convention in GitHub Actions workflows
- Updated references in playwright-reusable.yml and release-candidate.yml to use a consistent dot notation for Docker image names. - Ensured uniformity in the naming structure for better clarity and maintainability across workflows.
1 parent 3afa81a commit 9c0e9eb

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

.github/workflows/playwright-reusable.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ jobs:
143143
run: |
144144
# Try to pull the specific tag first
145145
BUNDLE_TAG="${{ inputs.container-tag }}"
146-
IMAGE_NAME="ghcr.io/0xfurai/peekaping-bundle-${{ matrix.database }}"
146+
IMAGE_NAME="ghcr.io/0xfurai/peekaping-bundle.${{ matrix.database }}"
147147
148148
echo "Checking if ${IMAGE_NAME}:${BUNDLE_TAG} exists..."
149149
@@ -156,7 +156,7 @@ jobs:
156156
else
157157
echo "❌ No bundle image found for ${{ matrix.database }}"
158158
echo "Available tags:"
159-
docker search --limit 5 "0xfurai/peekaping-bundle-${{ matrix.database }}" || echo "No public images found"
159+
docker search --limit 5 "0xfurai/peekaping-bundle.${{ matrix.database }}" || echo "No public images found"
160160
exit 1
161161
fi
162162
@@ -171,21 +171,21 @@ jobs:
171171
--name peekaping-bundle-test-${{ matrix.database }} \
172172
-p 8384:8383 \
173173
-v $(pwd)/test-data/sqlite/app:/app/data \
174-
ghcr.io/0xfurai/peekaping-bundle-${{ matrix.database }}:${BUNDLE_TAG}
174+
ghcr.io/0xfurai/peekaping-bundle.${{ matrix.database }}:${BUNDLE_TAG}
175175
;;
176176
mongo)
177177
docker run -d \
178178
--name peekaping-bundle-test-${{ matrix.database }} \
179179
-p 8384:8383 \
180180
-v $(pwd)/test-data/mongo/db:/data/db \
181-
ghcr.io/0xfurai/peekaping-bundle-${{ matrix.database }}:${BUNDLE_TAG}
181+
ghcr.io/0xfurai/peekaping-bundle.${{ matrix.database }}:${BUNDLE_TAG}
182182
;;
183183
postgres)
184184
docker run -d \
185185
--name peekaping-bundle-test-${{ matrix.database }} \
186186
-p 8384:8383 \
187187
-v $(pwd)/test-data/postgres/data:/var/lib/postgresql/data \
188-
ghcr.io/0xfurai/peekaping-bundle-${{ matrix.database }}:${BUNDLE_TAG}
188+
ghcr.io/0xfurai/peekaping-bundle.${{ matrix.database }}:${BUNDLE_TAG}
189189
;;
190190
esac
191191
@@ -246,6 +246,6 @@ jobs:
246246
- uses: actions/upload-artifact@v4
247247
if: ${{ !cancelled() }}
248248
with:
249-
name: playwright-report-bundle-${{ matrix.database }}-${{ inputs.container-tag }}
249+
name: playwright-report-bundle.${{ matrix.database }}-${{ inputs.container-tag }}
250250
path: playwright-report/
251251
retention-days: 30

.github/workflows/release-candidate.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -241,14 +241,14 @@ jobs:
241241
uses: docker/build-push-action@v6
242242
with:
243243
context: .
244-
file: ./infra/Dockerfile.bundle-${{ matrix.database }}
244+
file: ./infra/Dockerfile.bundle.${{ matrix.database }}
245245
push: true
246246
platforms: ${{ matrix.platform }}
247247
provenance: false
248248
sbom: false
249249
tags: |
250-
ghcr.io/${{ github.repository_owner }}/${{ github.event.repository.name }}-bundle-${{ matrix.database }}:${{ github.event.inputs.version }}-${{ matrix.arch }}
251-
${{ secrets.DOCKERHUB_USERNAME }}/${{ github.event.repository.name }}-bundle-${{ matrix.database }}:${{ github.event.inputs.version }}-${{ matrix.arch }}
250+
ghcr.io/${{ github.repository_owner }}/${{ github.event.repository.name }}-bundle.${{ matrix.database }}:${{ github.event.inputs.version }}-${{ matrix.arch }}
251+
${{ secrets.DOCKERHUB_USERNAME }}/${{ github.event.repository.name }}-bundle.${{ matrix.database }}:${{ github.event.inputs.version }}-${{ matrix.arch }}
252252
cache-from: type=gha
253253
cache-to: type=gha,mode=max
254254

0 commit comments

Comments
 (0)