Fix sort instability in plot data ordering

Use sort.Stable instead of sort.Sort to ensure deterministic ordering
of data points with identical timestamps across different Go versions
and architectures. This fixes CI test failures.

Author: tsenart

lib/plot/plot.go

@@ -313,7 +313,7 @@ func (p *Plot) data() (dataPoints, []string, error) {
 		labels[i+1] = s.attack + ": " + s.label
 	}
 
-	sort.Sort(data)
+	sort.Stable(data)
 
 	return data, labels, nil
 }

lib/plot/testdata/TestPlot.golden.html

@@ -330,8 +330,8 @@ <h1>TestPlot</h1>
      ]
     };
       const rowData = [
-    [0,null,0,null],
     [0,1,null,null],
+    [0,null,0,null],
     [0,null,null,0],
     [0.088,null,26,null],
     [0.105,26,null,null],
@@ -409,8 +409,8 @@ <h1>TestPlot</h1>
     [6.13,227,null,null],
     [6.231,null,29,null],
     [6.283,0,null,null],
-    [6.284,null,null,0],
     [6.284,null,0,null],
+    [6.284,null,null,0],
     [6.7059999999999995,null,48,null],
     [6.772,null,null,101],
     [6.782,54,null,null],
@@ -432,8 +432,8 @@ <h1>TestPlot</h1>
     [8.042,null,null,0],
     [8.093,27,null,null],
     [8.146,null,984,null],
-    [8.292,null,0,null],
     [8.292,0,null,null],
+    [8.292,null,0,null],
     [8.399000000000001,null,null,43],
     [8.686,null,19,null],
     [8.711,null,null,80],
@@ -492,8 +492,8 @@ <h1>TestPlot</h1>
     [13.066,0,null,null],
     [13.128,null,null,80],
     [13.154,null,60,null],
-    [13.317,null,0,null],
     [13.317,33,null,null],
+    [13.317,null,0,null],
     [13.317,null,null,0],
     [13.568999999999999,null,23,null],
     [13.57,0,null,null],
@@ -555,9 +555,9 @@ <h1>TestPlot</h1>
     [18.433,59,null,null],
     [18.537,null,53,null],
     [18.575,null,null,24],
+    [18.593,0,null,null],
     [18.593,null,0,null],
     [18.593,null,null,0],
-    [18.593,0,null,null],
     [19.033,null,null,25],
     [19.044,null,19,null],
     [19.084,53,null,null],
@@ -576,21 +576,21 @@ <h1>TestPlot</h1>
     [20.102,0,null,null],
     [20.328,null,30,null],
     [20.345,null,null,19],
-    [20.352,null,null,0],
     [20.352,null,0,null],
+    [20.352,null,null,0],
     [20.372,13,null,null],
     [20.693,null,null,26],
     [20.723,null,29,null],
     [20.831,22,null,null],
-    [20.854,null,null,0],
     [20.854,0,null,null],
     [20.854,null,0,null],
+    [20.854,null,null,0],
     [21.13,41,null,null],
     [21.176,null,null,15],
     [21.207,null,23,null],
     [21.357,0,null,null],
-    [21.359,null,null,0],
     [21.359,null,0,null],
+    [21.359,null,null,0],
     [21.664,null,31,null],
     [21.669,36,null,null],
     [21.792,null,null,31],
@@ -609,8 +609,8 @@ <h1>TestPlot</h1>
     [22.864,null,null,0],
     [22.911,194,null,null],
     [23.104,null,41,null],
-    [23.116,null,0,null],
     [23.116,0,null,null],
+    [23.116,null,0,null],
     [23.145,null,null,11],
     [23.407,null,90,null],
     [23.408,null,null,27],
@@ -636,8 +636,8 @@ <h1>TestPlot</h1>
     [25.126,0,null,null],
     [25.157,null,null,40],
     [25.176,null,520,null],
-    [25.377,null,null,0],
     [25.377,null,1,null],
+    [25.377,null,null,0],
     [25.434,379,null,null],
     [25.629,0,null,null],
     [25.7,null,18,null],
@@ -648,17 +648,17 @@ <h1>TestPlot</h1>
     [26.263,null,null,45],
     [26.27,48,null,null],
     [26.354,null,31,null],
-    [26.382,null,null,0],
     [26.382,null,0,null],
+    [26.382,null,null,0],
     [26.384,0,null,null],
     [26.72,null,29,null],
     [26.725,null,null,47],
     [26.729,66,null,null],
     [26.885,0,null,null],
     [26.98,null,68,null],
     [27.083,null,null,104],
-    [27.136,null,0,null],
     [27.136,71,null,null],
+    [27.136,null,0,null],
     [27.136,null,null,0],
     [27.409,null,23,null],
     [27.537,null,null,32],
@@ -693,8 +693,8 @@ <h1>TestPlot</h1>
     [29.913,null,79,null],
     [30.092,null,null,31],
     [30.129,30,null,null],
-    [30.151,null,0,null],
     [30.151,0,null,null],
+    [30.151,null,0,null],
     [30.312,null,null,49],
     [30.404,null,null,0],
     [30.515,null,48,null],
@@ -714,8 +714,8 @@ <h1>TestPlot</h1>
     [31.692,null,29,null],
     [31.837,null,null,131],
     [31.866,91,null,null],
-    [31.909,null,0,null],
     [31.909,0,null,null],
+    [31.909,null,0,null],
     [31.909,null,null,0],
     [32.313,31,null,null],
     [32.329,null,null,28],
@@ -732,8 +732,8 @@ <h1>TestPlot</h1>
     [33.168,null,0,null],
     [33.376,null,null,38],
     [33.383,28,null,null],
-    [33.417,null,null,0],
     [33.417,0,null,null],
+    [33.417,null,null,0],
     [33.664,null,75,null],
     [33.668,null,0,null],
     [33.752,22,null,null],
@@ -750,15 +750,15 @@ <h1>TestPlot</h1>
     [34.673,null,0,null],
     [34.82,null,null,40],
     [34.873,55,null,null],
-    [34.924,null,null,0],
     [34.924,0,null,null],
+    [34.924,null,null,0],
     [34.967,null,12,null],
     [35.26,null,null,53],
     [35.294,null,35,null],
     [35.31,52,null,null],
-    [35.427,null,null,0],
     [35.427,0,null,null],
     [35.427,null,0,null],
+    [35.427,null,null,0],
     [35.708,15,null,null],
     [35.785,null,25,null],
     [35.908,null,null,20],
@@ -858,14 +858,14 @@ <h1>TestPlot</h1>
     [43.836,null,null,86],
     [43.957,null,26,null],
     [43.967,27,null,null],
-    [43.969,null,null,0],
     [43.969,null,0,null],
+    [43.969,null,null,0],
     [43.971,0,null,null],
     [44.223,null,null,29],
     [44.273,null,16,null],
     [44.36,65,null,null],
-    [44.473,null,0,null],
     [44.473,0,null,null],
+    [44.473,null,0,null],
     [44.682,null,null,41],
     [44.723,null,null,0],
     [44.781,null,34,null],
@@ -966,17 +966,17 @@ <h1>TestPlot</h1>
     [52.908,39,null,null],
     [52.93,null,23,null],
     [52.983,null,null,45],
-    [53.015,null,null,0],
     [53.015,null,0,null],
+    [53.015,null,null,0],
     [53.017,0,null,null],
     [53.288,null,38,null],
     [53.327,22,null,null],
     [53.43,null,null,23],
     [53.562,61,null,null],
     [53.688,null,null,136],
     [53.694,null,44,null],
-    [53.768,null,0,null],
     [53.768,138,null,null],
+    [53.768,null,0,null],
     [53.77,null,null,0],
     [54.02,0,null,null],
     [54.094,null,28,null],
@@ -987,8 +987,8 @@ <h1>TestPlot</h1>
     [54.522,0,null,null],
     [54.692,null,null,20],
     [54.701,null,145,null],
-    [54.773,null,null,0],
     [54.773,null,0,null],
+    [54.773,null,null,0],
     [54.822,19,null,null],
     [55.025,0,null,null],
     [55.078,null,92,null],
@@ -1059,8 +1059,8 @@ <h1>TestPlot</h1>
     [60.58,null,null,106],
     [60.715,null,48,null],
     [60.789,40,null,null],
-    [60.803,null,null,0],
     [60.803,0,null,null],
+    [60.803,null,null,0],
     [60.804,null,0,null],
     [61.161,21,null,null],
     [61.249,null,null,76],
@@ -1086,8 +1086,8 @@ <h1>TestPlot</h1>
     [62.815,null,0,null],
     [62.816,null,null,43],
     [62.946,40,null,null],
-    [63.065,null,null,0],
     [63.065,0,null,null],
+    [63.065,null,null,0],
     [63.251,null,36,null],
     [63.357,51,null,null],
     [63.469,null,null,17],
@@ -1140,14 +1140,14 @@ <h1>TestPlot</h1>
     [67.456,null,34,null],
     [67.501,31,null,null],
     [67.528,null,null,23],
+    [67.587,0,null,null],
     [67.587,null,0,null],
     [67.587,null,null,0],
-    [67.587,0,null,null],
     [67.917,23,null,null],
     [67.938,null,109,null],
     [67.95,null,null,40],
-    [68.09,null,null,0],
     [68.09,null,0,null],
+    [68.09,null,null,0],
     [68.11,121,null,null],
     [68.341,0,null,null],
     [68.357,null,292,null],
@@ -1164,8 +1164,8 @@ <h1>TestPlot</h1>
     [69.371,null,26,null],
     [69.423,null,null,35],
     [69.527,37,null,null],
-    [69.597,null,0,null],
     [69.597,0,null,null],
+    [69.597,null,0,null],
     [69.767,null,null,115],
     [69.849,null,null,0],
     [70.05,24,null,null],
@@ -1191,8 +1191,8 @@ <h1>TestPlot</h1>
     [71.697,null,null,16],
     [71.832,null,78,null],
     [71.847,26,null,null],
-    [71.858,null,0,null],
     [71.858,0,null,null],
+    [71.858,null,0,null],
     [72.102,null,null,60],
     [72.11,null,null,0],
     [72.162,63,null,null],
@@ -1203,8 +1203,8 @@ <h1>TestPlot</h1>
     [72.725,33,null,null],
     [72.815,null,null,40],
     [72.858,null,47,null],
-    [72.863,null,null,0],
     [72.863,0,null,null],
+    [72.863,null,null,0],
     [72.864,null,0,null],
     [73.138,null,null,19],
     [73.182,27,null,null],
@@ -1239,20 +1239,20 @@ <h1>TestPlot</h1>
     [75.753,38,null,null],
     [75.797,null,null,44],
     [75.801,null,16,null],
-    [75.878,null,null,0],
     [75.878,0,null,null],
+    [75.878,null,null,0],
     [76.066,null,29,null],
     [76.131,null,0,null],
     [76.157,null,null,19],
     [76.336,19,null,null],
-    [76.381,null,null,0],
     [76.381,0,null,null],
+    [76.381,null,null,0],
     [76.421,null,17,null],
     [76.656,null,33,null],
     [76.859,null,null,27],
     [76.88,24,null,null],
-    [76.883,null,0,null],
     [76.883,0,null,null],
+    [76.883,null,0,null],
     [76.883,null,null,0],
     [77.144,null,19,null],
     [77.251,null,null,33],
@@ -1299,8 +1299,8 @@ <h1>TestPlot</h1>
     [80.755,63,null,null],
     [80.824,null,19,null],
     [80.857,null,null,41],
-    [80.903,null,0,null],
     [80.903,0,null,null],
+    [80.903,null,0,null],
     [81.111,null,null,134],
     [81.155,null,null,0],
     [81.274,null,17,null],
@@ -1314,8 +1314,8 @@ <h1>TestPlot</h1>
     [81.908,0,null,null],
     [82.026,null,14,null],
     [82.129,null,null,21],
-    [82.16,null,null,0],
     [82.16,null,0,null],
+    [82.16,null,null,0],
     [82.254,26,null,null],
     [82.423,null,null,35],
     [82.447,null,10,null],
@@ -1362,8 +1362,8 @@ <h1>TestPlot</h1>
     [85.929,null,null,0],
     [85.964,43,null,null],
     [86.012,null,194,null],
-    [86.18,null,null,20],
     [86.18,0,null,null],
+    [86.18,null,null,20],
     [86.181,null,0,null],
     [86.431,null,null,0],
     [86.506,null,21,null],
@@ -1479,14 +1479,14 @@ <h1>TestPlot</h1>
     [95.757,14,null,null],
     [95.777,null,93,null],
     [95.828,null,null,50],
-    [95.978,null,null,0],
     [95.978,null,0,null],
+    [95.978,null,null,0],
     [96.085,52,null,null],
     [96.23,0,null,null],
     [96.381,null,null,96],
     [96.41,null,8,null],
-    [96.481,null,null,0],
     [96.481,null,0,null],
+    [96.481,null,null,0],
     [96.603,19,null,null],
     [96.732,0,null,null],
     [96.738,null,24,null],
@@ -1497,8 +1497,8 @@ <h1>TestPlot</h1>
     [97.235,null,null,0],
     [97.245,35,null,null],
     [97.408,null,68,null],
-    [97.486,null,0,null],
     [97.486,0,null,null],
+    [97.486,null,0,null],
     [97.525,null,null,61],
     [97.74,null,null,0],
     [97.849,null,25,null],
@@ -1527,8 +1527,8 @@ <h1>TestPlot</h1>
     [99.747,0,null,null],
     [99.815,null,null,71],
     [99.954,null,47,null],
-    [99.999,null,0,null],
     [99.999,0,null,null],
+    [99.999,null,0,null],
     [99.999,null,null,0]  ];