upcoming: [UIE-10432] - Implement drawer to reserve an IP address #9155
Annotations
12 warnings
|
ESLint Review (validation)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
ESLint Review (shared)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
ESLint Review (utilities)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
ESLint Review (queries)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
ESLint Review (api-v4)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
ESLint Review (ui)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
ESLint Review (manager)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
ESLint Review (manager):
packages/manager/src/features/ReservedIps/ReserveIPDrawer.tsx#L222
[eslint] reported by reviewdog 🐶
** No font weight declarations in our code in order to avoid faux-bold **.
We manage font weights through font family declarations.
For example, instead of specifying `fontWeight: "bold"`,
use: `fontFamily: theme.font.bold`.
Raw Output:
{"ruleId":"@linode/cloud-manager/no-custom-fontWeight","severity":1,"message":"** No font weight declarations in our code in order to avoid faux-bold **.
|
|
ESLint Review (manager):
packages/manager/src/features/ReservedIps/ReserveIPDrawer.tsx#L166
[eslint] reported by reviewdog 🐶
Unexpected lexical declaration in case block.
Raw Output:
{"ruleId":"no-case-declarations","severity":1,"message":"Unexpected lexical declaration in case block.","line":166,"column":11,"nodeType":"VariableDeclaration","messageId":"unexpected","endLine":170,"endColumn":14,"suggestions":[{"messageId":"addBrackets","fix":{"range":[4864,5202],"text":"{ const reserved = await updateIP({
|
|
ESLint Review (manager):
packages/manager/src/features/ReservedIps/ReserveIPDrawer.tsx#L156
[eslint] reported by reviewdog 🐶
Unexpected lexical declaration in case block.
Raw Output:
{"ruleId":"no-case-declarations","severity":1,"message":"Unexpected lexical declaration in case block.","line":156,"column":11,"nodeType":"VariableDeclaration","messageId":"unexpected","endLine":159,"endColumn":14,"suggestions":[{"messageId":"addBrackets","fix":{"range":[4541,4829],"text":"{ const edited = await updateReservedIP({
|
|
ESLint Review (manager):
packages/manager/src/features/ReservedIps/ReserveIPDrawer.tsx#L149
[eslint] reported by reviewdog 🐶
Unexpected lexical declaration in case block.
Raw Output:
{"ruleId":"no-case-declarations","severity":1,"message":"Unexpected lexical declaration in case block.","line":149,"column":11,"nodeType":"VariableDeclaration","messageId":"unexpected","endLine":149,"endColumn":76,"suggestions":[{"messageId":"addBrackets","fix":{"range":[4275,4509],"text":"{ const created = await reserveIP({ region: values.region, tags });
|
|
ESLint Review (manager):
packages/manager/src/features/ReservedIps/ReserveIPDrawer.test.tsx#L114
[eslint] reported by reviewdog 🐶
Define a constant instead of duplicating this literal 3 times.
Raw Output:
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 3 times.","line":114,"column":6,"nodeType":"Literal","endLine":114,"endColumn":33}
|